Add verify step to confirm correct ranked flag
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Apr 11, 2024
| @@ -188,6 +189,13 @@ public async Task<int> OnExecuteAsync(CancellationToken cancellationToken) | |||
| sqlBuffer.Append($"UPDATE scores SET pp = {importedScore.HighScore.pp.ToString() ?? "NULL"} WHERE id = {importedScore.id};"); | |||
| } | |||
|
|
|||
| if (!check(importedScore.id, "ranked", importedScore.ranked, true)) | |||
There was a problem hiding this comment.
I guess this implicitly assumes that every score in the high tables is automatically ranked, but what about the hidden flag in those tables? Are we handling that elsewhere already? I don't think we are, or at least I can't see it happening in code...
There was a problem hiding this comment.
Hidden is exclusively used for restricted users, which is handled as part of the ES indexing step these days. So for the time being we do just import these scores to the new table with no consideration of the flag, and leave that to es indexer to get right.
bdach
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I cannot fathom, some imported scores have
rankedset to zero. These look to be older imports, and new cases are not showing up, so let's just fix those and call it a day.This assumes that if a score still exists in
osu_scores_highthen it is valid for leaderboards.Closes #252 (already ran on the affected score; running over all scores overnight).