Explicitly specify NC/DC as mods valid for PP #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Oct 20, 2023
| @@ -163,13 +163,27 @@ public static bool AllModsValidForPerformance(Mod[] mods) | |||
| case ManiaModKey10: | |||
| return false; | |||
|
|
|||
| case ModNightcore nc: | |||
There was a problem hiding this comment.
wonder if it's worth casing ModRateAdjust at the end of the switch to cover all of these? rather than having individual handling?
There was a problem hiding this comment.
Doesn't it feel iffy to blindly allow all rate adjust mods?
There was a problem hiding this comment.
Judging that we're in this predicament due to relying on inheritance hierarchies, I think specifying mod classes explicitly is better.
You could maybe try to keep one unified copy of the code under four case labels. Maybe.
There was a problem hiding this comment.
You could maybe try to keep one unified copy of the code under four case labels. Maybe.
Might read better, not fussed either way just curious on preference.
peppy
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of ppy/osu#24640, NC no longer inherits DT and DC no longer inherits HT.
This can be merged as is without an update to nuget packages.