-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currency: Created build script and build_info.json for Bottleneck #5120
Merged
nikhil-kalbande
merged 8 commits into
ppc64le:python-ecosystem
from
Harithanagothu2:bottleneck_3
Dec 31, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f0e6784
Create bottleneck_1.3.5_ubi_9.3.sh
Harithanagothu2 be85361
Update build_info.json
Harithanagothu2 5dd4244
Merge branch 'python-ecosystem' into bottleneck_3
Harithanagothu2 247fcb1
Update build_info.json
Harithanagothu2 039b839
Update bottleneck_1.3.5_ubi_9.3.sh
Harithanagothu2 a7f6afb
Update bottleneck_1.3.5_ubi_9.3.sh
Harithanagothu2 c3ae6c0
Update bottleneck_1.3.5_ubi_9.3.sh
Harithanagothu2 c42a0fd
Update build_info.json
Harithanagothu2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,11 +7,10 @@ | |
"package_dir": "b/bottleneck", | ||
"build_script": "bottleneck_1.3.5_ubi_9.3.sh", | ||
"wheel_build" : true, | ||
"docker_build": true, | ||
"docker_build": false, | ||
"validate_build_script": true, | ||
"use_non_root_user": false, | ||
"v1.*.*": { | ||
"dir": "ubi9_3", | ||
"build_script": "bottleneck_1.3.5_ubi_9.3.sh" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you will need dockerfile as docker_build = "true" here |
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need to just do pip install ... this will just install dependencies from requirement.txt