Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency: Created build script and build_info.json for Bottleneck #5120

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions b/bottleneck/bottleneck_1.3.5_ubi_9.3.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,29 +22,27 @@
PACKAGE_NAME=bottleneck
PACKAGE_VERSION=${1:-v1.3.5}
PACKAGE_URL=https://github.com/pydata/bottleneck.git

# Install dependencies and tools.
yum install -y wget gcc gcc-c++ gcc-gfortran git make python-devel openssl-devel

#clone repository
git clone $PACKAGE_URL
cd $PACKAGE_NAME
git checkout $PACKAGE_VERSION

pip install .


#install
if ! (python3 setup.py install) ; then
if ! (pip install .) ; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to just do pip install ... this will just install dependencies from requirement.txt

echo "------------------$PACKAGE_NAME:Install_fails-------------------------------------"
echo "$PACKAGE_URL $PACKAGE_NAME"
echo "$PACKAGE_NAME | $PACKAGE_URL | $PACKAGE_VERSION | GitHub | Fail | Install_Fails"
exit 1
fi

pip install chardet --upgrade
pip install requests --upgrade
pip install tox

#test
if ! tox -e py39; then
echo "--------------------$PACKAGE_NAME:Install_success_but_test_fails---------------------"
Expand Down
3 changes: 1 addition & 2 deletions b/bottleneck/build_info.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,10 @@
"package_dir": "b/bottleneck",
"build_script": "bottleneck_1.3.5_ubi_9.3.sh",
"wheel_build" : true,
"docker_build": true,
"docker_build": false,
"validate_build_script": true,
"use_non_root_user": false,
"v1.*.*": {
"dir": "ubi9_3",
"build_script": "bottleneck_1.3.5_ubi_9.3.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will need dockerfile as docker_build = "true" here

}
}