-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knative Eventing Kafka Broker - prow jobs to run upstream testing CI job #522
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kabhiibm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @kabhiibm. Thanks for your PR. I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The following PR #523 needs to be merged before this one can be merged. |
f8678db
to
f6ece80
Compare
The updated changes are included. @Rajalakshmi-Girish, please have a look and do the needful. |
config/jobs/periodic/knative-extensions/eventing-kafka-broker/eventing-kafka-broker-main.yaml
Show resolved
Hide resolved
pushd $GOPATH/src/github.com/knative-extensions/eventing-kafka-broker | ||
. /tmp/adjust.sh | ||
./test/e2e-tests.sh --run-tests | ||
popd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we might consider having these lines that bring up cluster, running tests and cleanup in a common place. May be in your repository https://github.com/ppc64le-cloud/knative-upstream-ci to avoid duplication lines.
In most of the knative jobs these lines appear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valen-mascarenhas14 your opinion on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rajalakshmi-Girish Yes, that could be done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valen-mascarenhas14/ @kabhiibm Can you please do that and also apply to jobs in https://github.com/ppc64le-cloud/test-infra/tree/master/config/jobs/periodic/knative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted @Rajalakshmi-Girish
updated eventing kafka broker job config steps and knative ci repo updated
b98478d
to
1164b59
Compare
@Rajalakshmi-Girish , the jobs has been updated. Please have a look and do the needful to merge it. |
This PR refers dropping-off of Eventing Kafka Broker jobs from: drop s390x/ppc ci jobs #497.
Added updated prow jobs scripts to run Eventing Kafka Broker (main, release-1.16) testing CI jobs.
This PR requires depends on PR: ppc64le-cloud/knative-tkn-upstream-ci#17