Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative Eventing Kafka Broker - prow jobs to run upstream testing CI job #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kabhiibm
Copy link
Contributor

This PR refers dropping-off of Eventing Kafka Broker jobs from: drop s390x/ppc ci jobs #497.
Added updated prow jobs scripts to run Eventing Kafka Broker (main, release-1.16) testing CI jobs.
This PR requires depends on PR: ppc64le-cloud/knative-tkn-upstream-ci#17

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kabhiibm
Once this PR has been reviewed and has the lgtm label, please assign rajalakshmi-girish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 30, 2024
@ppc64le-cloud-bot
Copy link
Contributor

Hi @kabhiibm. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2024
@valen-mascarenhas14
Copy link
Contributor

The following PR #523 needs to be merged before this one can be merged.

@kabhiibm kabhiibm force-pushed the eventing-kafka-broker-dev branch from f8678db to f6ece80 Compare January 7, 2025 08:29
@kabhiibm
Copy link
Contributor Author

kabhiibm commented Jan 7, 2025

The following PR #523 needs to be merged before this one can be merged.

The updated changes are included. @Rajalakshmi-Girish, please have a look and do the needful.

cc @valen-mascarenhas14

pushd $GOPATH/src/github.com/knative-extensions/eventing-kafka-broker
. /tmp/adjust.sh
./test/e2e-tests.sh --run-tests
popd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we might consider having these lines that bring up cluster, running tests and cleanup in a common place. May be in your repository https://github.com/ppc64le-cloud/knative-upstream-ci to avoid duplication lines.
In most of the knative jobs these lines appear.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valen-mascarenhas14 your opinion on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajalakshmi-Girish Yes, that could be done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valen-mascarenhas14/ @kabhiibm Can you please do that and also apply to jobs in https://github.com/ppc64le-cloud/test-infra/tree/master/config/jobs/periodic/knative?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valen-mascarenhas14
Copy link
Contributor

@kabhiibm You'll have to modify this PR according to this PR #525

updated eventing kafka broker job config

steps and knative ci repo updated
@kabhiibm
Copy link
Contributor Author

@Rajalakshmi-Girish , the jobs has been updated. Please have a look and do the needful to merge it.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants