Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove twofortyfouram to fix broken builds (one possibility) #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xavron
Copy link

@Xavron Xavron commented Aug 28, 2024

If you want to go this way to fix the issue, then its here. I'd rather give you something instead of nothing. I won't likely be doing anything else for this so you'd have to if you want to go a different way.

o Removed fortytwofouram due to breaking the builds.

The choice is yours :)

@Xavron Xavron changed the title Remove twofortyfouram Remove twofortyfouram to fix broken builds Aug 28, 2024
@Xavron Xavron changed the title Remove twofortyfouram to fix broken builds Remove twofortyfouram to fix broken builds (one possibility) Aug 28, 2024
@constambeys
Copy link
Contributor

Yes build is broken, this should be merged !

@constambeys
Copy link
Contributor

Also the grandle properties needs to be checked is using some weird settings like

-org.gradle.unsafe.configuration-cache=true
-android.nonTransitiveRClass=false
-android.nonFinalResIds=false

@Xavron
Copy link
Author

Xavron commented Dec 9, 2024

Also the grandle properties needs to be checked is using some weird settings like

-org.gradle.unsafe.configuration-cache=true -android.nonTransitiveRClass=false -android.nonFinalResIds=false

Oh. If I'm looking at that right, it looks to be already in there: https://github.com/ppareit/swiftp/blob/master/gradle.properties

All I know is that I didn't think about it :)

Edit: I wasn't looking at it right lol. Looks like it showed up with commit 221cc02 and is a separate issue. Not related to this pull request. At least the unsafe cache is now outdated: https://docs.gradle.org/8.1/userguide/upgrading_version_8.html#configuration_caching_options_renamed but this should be dealt with elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants