Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphaned network policy resource #49

Merged
merged 7 commits into from
Feb 22, 2024
Merged

Conversation

rurkss
Copy link

@rurkss rurkss commented Feb 21, 2024

Fixes: #48

This PR aims to address an issue introduced in release 2.0.1, where the logic for generating network policy resources by the operator was changed. From version 2.0.1 onwards, the operator no longer generates network policies for Redis but failed to remove existing policies generated prior to this version. This PR introduces a check and removal process for that leftover network policiy.

@rurkss rurkss self-assigned this Feb 21, 2024
@rurkss rurkss requested a review from a team as a code owner February 21, 2024 21:10
operator/redisfailover/service/client.go Outdated Show resolved Hide resolved
operator/redisfailover/service/client.go Outdated Show resolved Hide resolved
@benlangfeld benlangfeld changed the title Remove remained network policy resource Remove orphaned network policy resource Feb 22, 2024
Copy link

@indiebrain indiebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦 🚀 🤖

@rurkss rurkss merged commit ad39869 into master Feb 22, 2024
11 checks passed
@rurkss rurkss deleted the remove_remained_resources branch February 22, 2024 14:56
@indiebrain indiebrain mentioned this pull request Feb 26, 2024
indiebrain added a commit that referenced this pull request Feb 26, 2024
Prepare the repository for tagging / release of version 2.1.0.

Note, this release contains a
[fix](#49) for
#48 - hence the minor
version upgrade.

References
----------

-
https://semver.org/#what-do-i-do-if-i-accidentally-release-a-backward-incompatible-change-as-a-minor-version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.1 is not functional in an application with a deny-all NetworkPolicy
3 participants