Add Redis Slave Endpoint to HAProxy Service configuration #35
Conversation
| @@ -186,6 +186,26 @@ func generateHAProxyConfigmap(rf *redisfailoverv1.RedisFailover, labels map[stri | |||
| server-template redis %d _redis._tcp.%s.%s.svc.cluster.local:%d check inter 1s resolvers k8s init-addr none | |||
| `, port, rf.Spec.Redis.Replicas, redisName, namespace, port) | |||
|
|
|||
| if rf.Spec.BootstrapNode != nil && rf.Spec.BootstrapNode.Port != rf.Spec.Redis.Port.ToString() { | |||
There was a problem hiding this comment.
Might be worth noting that the redis-operator already exposes Services to get at the "master" node, or "slave" nodes of a RedisFailover. I'm not sure I fully understand the cost/benefit equation of doing the same thing with more moving parts via HAProxy.
That said, BootstrapNode.Port is
If you are wanting to migrate off of a pre-existing Redis instance, you can provide a bootstrapNode to your RedisFailover resource spec...The Port that the target Redis address is listening to. Defaults to 6379.
I'm confused, so maybe I'm reading this code wrong. Wouldn't this expose the slave nodes of the Replicating RedisFailover on the Port that the "target"/source Redis instance is exposed on?
IF I've understood this correctly, had you considered the following alternatives that avoid overloading the meaning of the Bootstrap.Port:
- Expose the slaves on a static port. To be clear, I'm fan of this idea yet the redis-operator already does this for the metrics exporter(s)12; so it's not that far off script and we could make it more dynamic later if the need arises.
- Make the HAPRoxy ports configurable like the redis-operator already does for the Redis and Sentinel nodes.
Footnotes
This Pull Request presents a different method compared to [Add Redis Slave Endpoint to HAProxy Service configuration](#35). Here, the redis-operator will establish a completely new HAProxy service, designed to route traffic specifically to Redis instances functioning as slaves.
This PR introduces a new endpoint in the HAProxy Service, directing traffic to a Redis node with a 'slave' role in the cluster. The port for this is derived from the BootrapNode.Port setting. If this configuration is unset, the endpoint won't be established.
The fundamental concept of bootstrapping involves establishing a connection from a replica Redis cluster to the primary Redis cluster, specifically to its slave nodes. It seems logical to utilize Bootstrap.Port for the HAProxy service to target the slave node of the source Redis cluster.