Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated mocks #22

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix generated mocks #22

merged 1 commit into from
Nov 17, 2023

Conversation

indiebrain
Copy link

@indiebrain indiebrain commented Nov 17, 2023

Part of: https://nitro.powerhrg.com/runway/backlog_items/FVR-93

Fix the generated mocks

make test is currently failing because the generated mock references an undefined variable:

Error: mocks/service/k8s/Services.go:565:3: undefined: r1
Error: mocks/service/k8s/Services.go:567:3: undefined: r1
Error: mocks/service/k8s/Services.go:570:13: undefined: r1

This was probably introduced in merge from the upstream and not caught because we're still in the process of setting CI in this fork.

Fix the integration tests

The integration tests have also been broken since we added a configurable port to the Sentinels:

 # github.com/spotahome/redis-operator/test/integration/redisfailover_test [github.com/spotahome/redis-operator/test/integration/redisfailover.test]
Error: test/integration/redisfailover/creation_test.go:250:52: not enough arguments in call to c.redisClient.GetSentinelMonitor
	have (string)
	want (string, string)
FAIL	github.com/spotahome/redis-operator/test/integration/redisfailover [build failed]
FAIL
make: *** [Makefile:142: ci-integration-test] Error 1
Error: Process completed with exit code 2.

@indiebrain indiebrain self-assigned this Nov 17, 2023
@indiebrain indiebrain force-pushed the aaronk--fix-generated-mocks branch 5 times, most recently from 55d8859 to 3b32fab Compare November 17, 2023 19:03
@indiebrain indiebrain force-pushed the aaronk--fix-generated-mocks branch from 3b32fab to 2ffdd05 Compare November 17, 2023 19:10
@indiebrain indiebrain marked this pull request as ready for review November 17, 2023 19:21
@indiebrain indiebrain requested a review from a team November 17, 2023 19:21
@indiebrain indiebrain merged commit ddb3bfb into master Nov 17, 2023
8 checks passed
@indiebrain indiebrain deleted the aaronk--fix-generated-mocks branch November 17, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants