[PBNTR-740] Advanced Table - Add Table Props to Rails kit #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElisaShapiro
added
enhancement
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-740-add-table-props-to-advanced-table-rails |
nidaqg
approved these changes
Jan 9, 2025
ElisaShapiro
deleted the
PBNTR-740-add-table-props-to-advanced-table-rails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PBNTR-740 gives the rails Advanced Table kit access to all of the props of the rails Table kit under the hood via an optional
table_propsprop.I tested various table props locally, such as: container: false, sticky: true, vertical_border: true, striped: true, disable_hover: true.
The doc example matches the React kit's Table Prop doc example exhibiting container: false (so no outer top and side borders) and sticky: true (so sticky header happens when scrolling past table).
table_propsappears in the prop table at the bottom of the kit page.Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.- [ ] TESTS I have added test coverage to my code.