Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1465] Fix Linting Errors - Typeahead Kit #4053

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tomm1128
Copy link
Contributor

@Tomm1128 Tomm1128 commented Dec 23, 2024

What does this PR do? A clear and concise description with your runway ticket url.
This story fixes the typeahead kit linting errors.

Ran yarn eslint --fix for each file other than the index file and none of the warnings were corrected. I believe them to be unsafe changes and will require manual intervention.

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to 'Typeahead kit page
  2. Should still work as expected

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@Tomm1128 Tomm1128 added improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target labels Dec 23, 2024
@Tomm1128 Tomm1128 self-assigned this Dec 23, 2024
@Tomm1128 Tomm1128 requested a review from a team as a code owner December 23, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant