Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1614] Icon Circle Size Bug Fix #4045

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ASPhillips8
Copy link
Contributor

@ASPhillips8 ASPhillips8 commented Dec 20, 2024

What does this PR do? A clear and concise description with your runway ticket url.
This PR address sizing of the icon on the xxs variant for the icon circle kit. Adjusted icon to match desired 10px size set by design standards.

Story 1614

Screenshots: Screenshots to visualize your addition/change
Before:
Screenshot 2024-12-20 at 3 26 44 PM

After:
Screenshot 2024-12-20 at 3 27 27 PM

How to test? Steps to confirm the desired behavior:

  1. kits/icon_circle/react
  2. Scroll down to size varients
  3. Observe that xxs icon is not 10px
  4. See both React and Rails Kit

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@ASPhillips8 ASPhillips8 added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Needs Review minor Semver Target labels Dec 20, 2024
@ASPhillips8 ASPhillips8 self-assigned this Dec 20, 2024
@ASPhillips8 ASPhillips8 requested a review from a team as a code owner December 20, 2024 20:31
@jasperfurniss jasperfurniss added Code Approved Approved by a Playbook Admin and removed Needs Review labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants