Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1660] Upgrade react-dropzone to 14.3.5 and File Upload Kit #4037

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kangaree
Copy link
Contributor

What does this PR do?

  • Upgrade react-dropzone from 10.2.2 to 14.3.5 for React File Upload kit
  • Switch accept prop from array of strings to object pointing to array of strings. 13.0.0 release notes.
  • Use fileRejections instead of rejectedFiles which includes reason it was rejected. 11.0.0 release notes.
  • Fix TypeScript errors

Screenshots: Screenshots to visualize your addition/change
Screenshot 2024-12-19 at 2 43 19 PM

How to test? Steps to confirm the desired behavior:

  1. Go to /kits/file_upload/react
  2. Test every single doc example
  3. Test clicking the box, as well as dragging a file

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

Fix type errors
Only use maxSize in string if it's a number
Use readonly for FileRejections
Check if object isEmpty for custom message check
@kangaree kangaree added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) alpha minor Semver Target labels Dec 19, 2024
@kangaree kangaree requested a review from a team as a code owner December 19, 2024 19:48
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.9.0.pre.alpha.PLAY1660reactdropzone5020

Your Alpha for NPM is 14.9.0-alpha.PLAY1660reactdropzone5020

@jasperfurniss jasperfurniss added the Code Approved Approved by a Playbook Admin label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants