Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-716] Table kit: "Sticky Left Column" variant styling - React and Rails #4027

Merged
merged 14 commits into from
Dec 20, 2024

Conversation

skduncan
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
PBNTR-716

As a Playbook dev,
I want to add a dynamically rendering shadow to the right column of the "Sticky Left Column" doc example,
So that we can ensure continuity in our table kit design.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@skduncan skduncan added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target labels Dec 18, 2024
@skduncan skduncan requested a review from a team as a code owner December 18, 2024 14:03
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-716stickyleftcolvariant

nidaqg
nidaqg previously approved these changes Dec 18, 2024
Copy link
Contributor

@nidaqg nidaqg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only thing is that double border at the end of the table when you scroll all the day to the end. Approving this for now, I'm ok with tackling that separately if needed

@nidaqg nidaqg added Code Approved Approved by a Playbook Admin and removed Needs Review labels Dec 18, 2024
@nidaqg nidaqg removed the Code Approved Approved by a Playbook Admin label Dec 20, 2024
nidaqg
nidaqg previously approved these changes Dec 20, 2024
@nidaqg nidaqg added Code Approved Approved by a Playbook Admin and removed Code Approved Approved by a Playbook Admin labels Dec 20, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Dec 20, 2024
@jasperfurniss jasperfurniss merged commit e26a60f into master Dec 20, 2024
7 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-716_sticky_left_col_variant branch December 20, 2024 19:38
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.10.0.pre.rc.21
- NPM: 14.10.0-rc.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants