-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-716] Table kit: "Sticky Left Column" variant styling - React and Rails #4027
Conversation
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-716stickyleftcolvariant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only thing is that double border at the end of the table when you scroll all the day to the end. Approving this for now, I'm ok with tackling that separately if needed
You merged this pr to master branch: |
What does this PR do? A clear and concise description with your runway ticket url.
PBNTR-716
As a Playbook dev,
I want to add a dynamically rendering shadow to the right column of the "Sticky Left Column" doc example,
So that we can ensure continuity in our table kit design.
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.