[PLAY-1678] Dark Mode Audit - Gauge #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lsimmons98
added
milano
|
Dark mode looks great @Lsimmons98 ! Only thing is looks like you're changing the text color on the light mode by accident. Here's your review env: Here is prod:
|
|
My bad, should have caught that one. Just pushed up the improved code. @nidaqg |
nidaqg
approved these changes
Dec 18, 2024
nidaqg
added
Code Approved
Looks great! thanks for the quick fix! |
nidaqg
added
Ready for Release
|
You merged this pr to master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates Darkmode styling for the Gauge component
How to test?
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.