-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-694] SkeletonLoading User Component and Filter Component doc examples #4014
Merged
jasperfurniss
merged 7 commits into
master
from
PBNTR-694-skeleton-loading-kit-doc-examples
Dec 19, 2024
Merged
[PBNTR-694] SkeletonLoading User Component and Filter Component doc examples #4014
jasperfurniss
merged 7 commits into
master
from
PBNTR-694-skeleton-loading-kit-doc-examples
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElisaShapiro
added
milano
20 MAX - Deploy this PR to a review environment via Milano
improvement
This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG))
minor
Semver Target
labels
Dec 16, 2024
nickamantia
reviewed
Dec 17, 2024
playbook/app/pb_kits/playbook/pb_skeleton_loading/docs/_skeleton_loading_filter.jsx
Outdated
Show resolved
Hide resolved
nickamantia
approved these changes
Dec 17, 2024
nidaqg
approved these changes
Dec 17, 2024
Amax1296
added
the
Product Approved
pending technical review, OK to merge to master
label
Dec 18, 2024
jasperfurniss
deleted the
PBNTR-694-skeleton-loading-kit-doc-examples
branch
December 19, 2024 13:32
You merged this pr to master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Approved
Approved by a Playbook Admin
improvement
This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG))
milano
20 MAX - Deploy this PR to a review environment via Milano
minor
Semver Target
Product Approved
pending technical review, OK to merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PBNTR-694 requests the addition of two doc examples as outlined in the handoff here to the React SkeletonLoading beta kit - one demonstrating the use of the SkeletonLoading kit as an interim loading state for our User kit in two ways, the second for the Filter kit (also in two ways).
The goal for this kit is that using the SkeletonLoading kit and other code, we can mimic the shape of our other components and set a loading state for them accordingly. These doc examples demonstrate to devs how to use the SkeletonLoading kit + other Playbook kits as building blocks to construct loading interims.
This PR also contains a small update adding the correct Dark Mode styles to the containing cards in the Height & Width doc example (just needed to carry
{...props}
through). See third screenshot below.Screenshots: Screenshots to visualize your addition/change
User Component doc example
Filter Component doc example
Height & Width doc example dark mode update
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.- [] TESTS I have added test coverage to my code.