Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1623] Icon Integration Docs: Nav Bar and About Page #4007

Merged
merged 9 commits into from
Dec 20, 2024
Merged

[PLAY-1623] Icon Integration Docs: Nav Bar and About Page #4007

merged 9 commits into from
Dec 20, 2024

Conversation

kangaree
Copy link
Contributor

@kangaree kangaree commented Dec 13, 2024 •
edited
Loading

What does this PR do?

  • Create Icon Integration Doc
  • Add a Nav Bar (modeled after the changelog nav bar)
  • Move Font Awesome under /icons/font_awesome
  • Create blank pages for Playbook Icons and Custom

https://runway.powerhrg.com/backlog_items/PLAY-1623

Screenshots: Screenshots to visualize your addition/change
Screenshot 2024-12-16 at 8 55 35 AM

How to test? Steps to confirm the desired behavior:

  1. Go to /guides/getting_started/icons/
  2. Click Font Awesome
  3. Click Playbook Icons and Custom

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@kangaree kangaree requested a review from a team as a code owner December 13, 2024 18:57
@kangaree kangaree added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target labels Dec 13, 2024
markdoeswork
markdoeswork approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@markdoeswork markdoeswork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jasperfurniss jasperfurniss added Code Approved Approved by a Playbook Admin and removed Needs Review labels Dec 18, 2024
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released Product Approved pending technical review, OK to merge to master labels Dec 20, 2024
@jasperfurniss jasperfurniss merged commit 4a0f70c into master Dec 20, 2024
14 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1623-icon-docs-phase-3 branch December 20, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdoeswork markdoeswork markdoeswork approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees
No one assigned
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kangaree @jasperfurniss @markdoeswork @nidaqg