Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1500] Home Address Street: "none" Emphasis Prop #4006

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

Tomm1128
Copy link
Contributor

@Tomm1128 Tomm1128 commented Dec 12, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Added a "none" option to emphasis prop in Home Address Kit so there can be an emphasized version of the kit.

PLAY-1500

Screenshots: Screenshots to visualize your addition/change

Screenshot 2024-12-12 at 1 13 49 PM

How to test? Steps to confirm the desired behavior:

  1. kits/home_address_street/
  2. Scroll down to emphasis example
  3. See new none emphasis example with documentation underneath
  4. Check both react and rails.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@Tomm1128 Tomm1128 added improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target labels Dec 12, 2024
@Tomm1128 Tomm1128 self-assigned this Dec 12, 2024
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1500-home-address-unstyled

@Tomm1128
Copy link
Contributor Author

Still need to implement rails version

@Tomm1128 Tomm1128 marked this pull request as ready for review December 12, 2024 18:48
@Tomm1128 Tomm1128 requested a review from a team as a code owner December 12, 2024 18:48
@Tomm1128 Tomm1128 added the milano 20 MAX - Deploy this PR to a review environment via Milano label Dec 12, 2024
@jasperfurniss jasperfurniss added the Code Approved Approved by a Playbook Admin label Dec 13, 2024
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released Product Approved pending technical review, OK to merge to master labels Dec 20, 2024
@jasperfurniss jasperfurniss merged commit 87b2580 into master Dec 20, 2024
11 checks passed
@jasperfurniss jasperfurniss deleted the play-1500-home-address-unstyled branch December 20, 2024 14:10
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.10.0.pre.rc.20
- NPM: 14.10.0-rc.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants