Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1701] Change Playground Key #3984

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[PLAY-1701] Change Playground Key #3984

merged 1 commit into from
Dec 9, 2024

Conversation

Lsimmons98
Copy link
Contributor

@Lsimmons98 Lsimmons98 commented Dec 6, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Stops "Warning: Encountered two children with the same key, 'top-nav-item-6'" from appearing in the console when loading playbook.

PLAY-1701

How to test? Steps to confirm the desired behavior:

  1. Go to playbook website, basically any page, with the console open.
  2. Check for "Warning: Encountered two children with the same key, 'top-nav-item-6'"

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@Lsimmons98 Lsimmons98 added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Dec 6, 2024
@Lsimmons98 Lsimmons98 self-assigned this Dec 6, 2024
@Lsimmons98 Lsimmons98 requested a review from a team as a code owner December 6, 2024 19:42
@Lsimmons98 Lsimmons98 added the minor Semver Target label Dec 6, 2024
@jasperfurniss jasperfurniss merged commit d5e29a8 into master Dec 9, 2024
9 of 11 checks passed
@jasperfurniss jasperfurniss deleted the play-1701-bug branch December 9, 2024 16:39
Copy link

github-actions bot commented Dec 9, 2024

You merged this pr to master branch:
- Ruby Gem: 14.10.0.pre.rc.10
- NPM: 14.10.0-rc.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants