Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1670] Dark Mode Audit - Typeahead #3983

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

Lsimmons98
Copy link
Contributor

@Lsimmons98 Lsimmons98 commented Dec 6, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Updates Darkmode styling for the Typeahead component

PLAY-1670

How to test? Steps to confirm the desired behavior:

  1. Go to '/kits/typeahead'
  2. Observe improved darkmode styling
Screenshot 2024-12-05 at 3 21 36 PM Screenshot 2024-12-05 at 3 22 07 PM Screenshot 2024-12-06 at 1 52 37 PM Screenshot 2024-12-06 at 1 54 49 PM

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@Lsimmons98 Lsimmons98 added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target labels Dec 6, 2024
@Lsimmons98 Lsimmons98 requested a review from a team as a code owner December 6, 2024 18:56
@Lsimmons98 Lsimmons98 self-assigned this Dec 6, 2024
jasperfurniss
jasperfurniss previously approved these changes Dec 10, 2024
@jasperfurniss jasperfurniss added the Code Approved Approved by a Playbook Admin label Dec 10, 2024
@jasperfurniss jasperfurniss added the Code Approved Approved by a Playbook Admin label Dec 17, 2024
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released Product Approved pending technical review, OK to merge to master labels Dec 20, 2024
@jasperfurniss jasperfurniss merged commit 65c8939 into master Dec 20, 2024
12 checks passed
@jasperfurniss jasperfurniss deleted the play-1670-darkmode branch December 20, 2024 14:04
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.10.0.pre.rc.19
- NPM: 14.10.0-rc.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants