Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1617] Change Bar Graph Override Example #3982

Merged
merged 10 commits into from
Dec 13, 2024
Merged

[PLAY-1617] Change Bar Graph Override Example #3982

merged 10 commits into from
Dec 13, 2024

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Dec 6, 2024 •
edited by kangaree
Loading

What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1617

Make visual updates to the bar graph doc example for custom overrides

How to test? Steps to confirm the desired behavior:

  1. Go to https://pr3982.playbook.beta.gm.powerapp.cloud/kits/bar_graph/react#custom-overrides
  2. Look at how great the chart is
  3. Rails too https://pr3982.playbook.beta.gm.powerapp.cloud/kits/bar_graph/rails#custom-overrides

Screenshot 2024-12-13 at 8 27 41 AM

@markdoeswork markdoeswork self-assigned this Dec 6, 2024
@markdoeswork markdoeswork added milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Dec 6, 2024
@markdoeswork markdoeswork changed the title Change react example Change Bar Graph Override Example Dec 6, 2024
@markdoeswork markdoeswork removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Dec 6, 2024
@markdoeswork markdoeswork added the milano 20 MAX - Deploy this PR to a review environment via Milano label Dec 6, 2024
@markdoeswork markdoeswork marked this pull request as ready for review December 9, 2024 20:40
@markdoeswork markdoeswork requested a review from a team as a code owner December 9, 2024 20:40
kangaree
kangaree previously approved these changes Dec 10, 2024
View reviewed changes
@markdoeswork markdoeswork changed the title Change Bar Graph Override Example [PLAY-1617] Change Bar Graph Override Example Dec 10, 2024
@markdoeswork markdoeswork added enhancement New Features, Props, & Variants (USED IN CHANGELOG) improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) and removed enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Dec 10, 2024
@jasperfurniss jasperfurniss added the Code Approved Approved by a Playbook Admin label Dec 13, 2024
@jasperfurniss jasperfurniss merged commit f07a662 into master Dec 13, 2024
7 checks passed
@jasperfurniss jasperfurniss deleted the play/1617_bar_graph_custom_overrides_doc_update branch December 13, 2024 14:26
@github-actions GitHub Actions
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.10.0.pre.rc.14
- NPM: 14.10.0-rc.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@kangaree kangaree kangaree left review comments

Assignees

@markdoeswork markdoeswork

@ASPhillips8 ASPhillips8

Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markdoeswork @jasperfurniss @kangaree @ASPhillips8