Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1634] Avatar Badge Overlay Border Bug Fix #3976

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

ASPhillips8
Copy link
Contributor

@ASPhillips8 ASPhillips8 commented Dec 5, 2024

What does this PR do? A clear and concise description with your runway ticket url.

This pr addresses the bug occurring on Overlay boarder for positioning of icon or badge overlay when positioned top center, bottom center, left center, or right center. Removed padding that was only present for centered positions

Story 1634

Screenshots: Screenshots to visualize your addition/change
Before:
Screenshot 2024-12-05 at 4 50 41 PM

After:

Screenshot 2024-12-05 at 4 54 51 PM

How to test? Steps to confirm the desired behavior:

  1. Go to '/kits/avatar/react'
  2. Scroll down to 'Badge Component Overlay'
  3. See that border is same for center positions and all other position placement.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@ASPhillips8 ASPhillips8 added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Needs Review minor Semver Target labels Dec 5, 2024
@ASPhillips8 ASPhillips8 self-assigned this Dec 5, 2024
@ASPhillips8 ASPhillips8 requested a review from a team as a code owner December 5, 2024 22:05
Copy link
Contributor

@nidaqg nidaqg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nidaqg nidaqg added Code Approved Approved by a Playbook Admin and removed Needs Review labels Dec 6, 2024
@jasperfurniss jasperfurniss merged commit 77cc548 into master Dec 9, 2024
16 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1634-Avatar_Badge_Overlay branch December 9, 2024 16:12
Copy link

github-actions bot commented Dec 9, 2024

You merged this pr to master branch:
- Ruby Gem: 14.10.0.pre.rc.8
- NPM: 14.10.0-rc.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants