Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-738] Collapsible Rows for Basic Table #3967

Merged
merged 14 commits into from
Dec 12, 2024

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Dec 2, 2024

Runway Story

Original POC story here

This PR:

  • ✅ Adds the tag prop to Collapsible kit
  • ✅ Adds collapsible kit to Table kit behind the collapsible prop
  • ✅ Adds collapsibleContent prop that consumes a component that will render within the collapsible
  • ✅ Adds collapsibleSideHighlight which renders the sidehighlight (true by default but can be set to false).
  • ✅ Adds prop to make it so devs can set only icon cell be clickable
  • ✅ Adds doc examples for each of the designs under 'collapsed content' in the handoff
Screenshot 2024-12-03 at 10 00 45 PM Screenshot 2024-12-03 at 10 00 54 PM Screenshot 2024-12-03 at 10 01 01 PM Screenshot 2024-12-03 at 10 01 08 PM Screenshot 2024-12-03 at 10 01 15 PM

@nidaqg nidaqg self-assigned this Dec 2, 2024
@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Dec 2, 2024
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-738-collapsible-within-table-kit

@nidaqg nidaqg marked this pull request as ready for review December 4, 2024 15:18
@nidaqg nidaqg requested a review from a team as a code owner December 4, 2024 15:18
ElisaShapiro
ElisaShapiro previously approved these changes Dec 4, 2024
Copy link
Contributor

@ElisaShapiro ElisaShapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc examples look great!

jasperfurniss
jasperfurniss previously approved these changes Dec 5, 2024
@jasperfurniss jasperfurniss added the Code Approved Approved by a Playbook Admin label Dec 9, 2024
@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master alpha labels Dec 10, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.9.0.pre.alpha.PBNTR738collapsiblewithintablekit4855

Your Alpha for NPM is 14.9.0-alpha.PBNTR738collapsiblewithintablekit4855

@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Dec 11, 2024
@jasperfurniss jasperfurniss merged commit f9be357 into master Dec 12, 2024
13 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-738-collapsible-within-table-kit branch December 12, 2024 21:33
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.10.0.pre.rc.13
- NPM: 14.10.0-rc.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants