[PLAY-1668] Dark Mode Audit - Selectable Card #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lsimmons98
added
the
milano
Lsimmons98
added
improvement
nidaqg
previously approved these changes
Nov 27, 2024
ElisaShapiro
previously approved these changes
Nov 27, 2024
nidaqg
previously approved these changes
Nov 27, 2024
Lsimmons98
changed the title
Lsimmons98
added
milano
|
Looks great @Lsimmons98! But looks like the jump Jason pointed out on the runway story is still there |
Took a look at this again with @Lsimmons98 and looks like that jump is happening in prod as well so unrelated to his changes. That being said, we can always tackle that 'bug' on a different story so marking my approval here! |
nidaqg
approved these changes
Dec 5, 2024
|
You merged this pr to master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Updates to dark mode styling based on audit for the Select-able Card component.
PLAY-1668
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.