[PLAY-1680] Width Global Prop #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Adjusted max width prop as well for 100% max width.
skduncan
added
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.8.0.pre.alpha.PLAY1680newwidthprop4661 Your Alpha for NPM is 14.8.0-alpha.PLAY1680newwidthprop4661 |
…n by global prop. Also, fixed issue with rails side prop not working in general
playbook-website/app/javascript/components/VisualGuidelines/Examples/Width.tsx
Show resolved
Hide resolved
nidaqg
reviewed
Nov 27, 2024
playbook-website/app/javascript/site_styles/_visual_guidelines.scss
Outdated
Show resolved
Hide resolved
jasperfurniss
previously approved these changes
Nov 27, 2024
jasperfurniss
approved these changes
Nov 27, 2024
nidaqg
added
Ready for Release
|
You merged this pr to master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1680
Adding new Width Prop to our global props list. Some minor updates to Max and Min Width props.
Screenshots: Screenshots to visualize your addition/change
