Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-661] Create a "stickyLeftcolumn" prop for the Table kit #3913

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Nov 15, 2024

PBNTR-661

Adds a stickyLeftcolumn prop. You need to pass in an array with strings of the columns you want sticky. Also you need to give ids to the columns you want sticky.

Screenshot 2024-11-18 at 11 46 23 AM

How to test? Steps to confirm the desired behavior:

  1. Go to the Table kit and look at the new doc examples

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia self-assigned this Nov 15, 2024
@nickamantia nickamantia added the enhancement New Features, Props, & Variants (USED IN CHANGELOG) label Nov 15, 2024
@nickamantia nickamantia added minor Semver Target milano 20 MAX - Deploy this PR to a review environment via Milano labels Nov 18, 2024
@nickamantia nickamantia marked this pull request as ready for review November 18, 2024 16:54
@nickamantia nickamantia requested a review from a team as a code owner November 18, 2024 16:54
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-661-create-sticky-left-prop

jasperfurniss
jasperfurniss previously approved these changes Nov 21, 2024
@jasperfurniss jasperfurniss added Code Approved Approved by a Playbook Admin and removed Needs Review labels Nov 21, 2024
nidaqg
nidaqg previously approved these changes Nov 21, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.8.0.pre.alpha.pbntr661createstickyleftprop4612

Your Alpha for NPM is 14.8.0-alpha.pbntr661createstickyleftprop4612

@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Nov 26, 2024
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Nov 26, 2024
@nickamantia nickamantia merged commit 3655c1c into master Nov 26, 2024
4 checks passed
@nickamantia nickamantia deleted the pbntr-661-create-sticky-left-prop branch November 26, 2024 16:46
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.9.0.pre.rc.9
- NPM: 14.9.0-rc.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants