[PLAY-1627] Fix Height Prop for HtmlOptions Support #3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperfurniss
added
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.6.2.pre.alpha.PLAY15814348 Your Alpha for NPM is 14.6.2-alpha.PLAY15814348 |
jasperfurniss
changed the title
jasperfurniss
added
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.6.2.pre.alpha.PLAY15814384 Your Alpha for NPM is 14.6.2-alpha.PLAY15814384 |
nidaqg
previously approved these changes
Nov 6, 2024
Amax1296
added
the
Product Approved
nidaqg
approved these changes
Nov 8, 2024
|
You merged this pr to master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
https://runway.powerhrg.com/backlog_items/PLAY-1627
Screenshots: Screenshots to visualize your addition/change
The htmlOptions now works, even with the addition of our new height prop.
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.- [ ] TESTS I have added test coverage to my code.