Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1479] Beta Link Kit #3852

Merged
merged 29 commits into from
Oct 29, 2024
Merged

[PLAY-1479] Beta Link Kit #3852

merged 29 commits into from
Oct 29, 2024

Conversation

kangaree
Copy link
Contributor

What does this PR do?

  • Create a Link Kit for Rails and React.
  • Add color, dark, disabled, icon, icon right, tag, and underline props

PLAY-1479

Screenshots: Screenshots to visualize your addition/change
Screenshot 2024-10-25 at 9 52 18 AM

How to test? Steps to confirm the desired behavior:

  1. Go to /kits/link/
  2. Test Rails and React
  3. Compare the handoff to each prop
  4. Visit the link (in a non-incognito window). Go back, the link should be purple and "visited"
  5. Hover over links to see the color
  6. "Focus" on the link by tabbing until you hit the link
  7. Use dark mode

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

kangaree added 24 commits October 21, 2024 14:08
@kangaree
Generate Link kit
e94670f
@kangaree
Correct generated errors
7c16df2
@kangaree
Link WIP
efc9040
@kangaree
Switch out link mixins file (but keep body mixins)
7c9b436
@kangaree
Add href prop to react link
5b0c88a
@kangaree
Use default, body, muted, and destructive colors
2975d4a
@kangaree
Add underlined prop
245d534
@kangaree
Remove swift docs
3f76963
@kangaree
Remove extra body features/styles and combine
eb6cb90 
Delete highlight and status
Combine scss into one sheet
Change variant from null to empty string
@kangaree
Set hover colors
cb804bf
@kangaree
Correct scss syntax
4c5604e
@kangaree
Add focus-visible rounded offset outline
655f543
@kangaree
Add visited color
b8baf81
@kangaree
Add disabled class (not an attribute for 'a' tags)
0ff3e8c
@kangaree
Add icon and icon right
2f084b4
@kangaree
Break out link examples
48144dd
@kangaree
Change hrefs for link examples
8eac6c3
@kangaree
Change underlined prop name to underline
d53dbe1
@kangaree
Create link ruby and JS tests
da2a1dd
@kangaree
Wrap with <a> tag if a tag other than <a> is passed
6ce62d7 
Remove scss that's not color
Add examples
@kangaree
Add props to tag doc examples
67f36d2
@kangaree
Add dark colors and remove cruft
7a33cf3
@kangaree
DRY up rails link. Correct margin icon prop
b10322e
@kangaree
Organize and DRY React link component
da3e417
@kangaree kangaree added new kit Use this when adding a new kit to Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 25, 2024
@kangaree kangaree requested review from a team as code owners October 25, 2024 13:56
@kangaree kangaree added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 25, 2024
skduncan
skduncan previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@skduncan skduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasperfurniss jasperfurniss added the Code Approved Approved by a Playbook Admin label Oct 29, 2024
@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Oct 29, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Oct 29, 2024
Merged via the queue into master with commit 7a92d5e Oct 29, 2024
7 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1479-link-kit branch October 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidaqg nidaqg nidaqg approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@skduncan skduncan skduncan left review comments

Assignees

@kangaree kangaree

Labels
Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano new kit Use this when adding a new kit to Playbook (USED IN CHANGELOG) Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kangaree @jasperfurniss @skduncan @nidaqg