[PLAY-1587] Group hover Global Prop #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdoeswork
added
enhancement
jasperfurniss
previously approved these changes
Oct 23, 2024
ElisaShapiro
previously approved these changes
Oct 23, 2024
markdoeswork
dismissed stale reviews from ElisaShapiro and jasperfurniss
via
1bd39af
markdoeswork
force-pushed
the
play/1587_group_hover_global_prop
branch
from
1bd39af to
78259d3
Compare
nidaqg
approved these changes
Oct 31, 2024
nidaqg
added
Product Approved
jasperfurniss
approved these changes
Nov 5, 2024
|
You merged this pr to master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1587
This story adds a new global prop, Group Hover
When you add the
group_hoverprop to a kit and the children inside that kit. The children's hover effects will take place when the parent is hovered.You just need to pass the
group_hover: trueorgroupHoverglobal prop to the parent and children(s)Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.