Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-555] Currency Kit Updates #3832

Merged
merged 11 commits into from
Oct 30, 2024
Merged

[PBNTR-555] Currency Kit Updates #3832

merged 11 commits into from
Oct 30, 2024

Conversation

jasperfurniss
Copy link
Contributor

@jasperfurniss jasperfurniss commented Oct 21, 2024

What does this PR do? A clear and concise description with your runway ticket url.
https://runway.powerhrg.com/backlog_items/PBNTR-555

Screenshots: Screenshots to visualize your addition/change
Screenshot 2024-10-22 at 3 53 03 PM

How to test? Steps to confirm the desired behavior:

  1. Go to bottom of Currency kit on rails & react.
  2. See new doc examples highlighting the new comma_separator prop.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@jasperfurniss jasperfurniss changed the title Initial Commit Currency Kit Updates Oct 22, 2024
@jasperfurniss jasperfurniss changed the title Currency Kit Updates [PBNTR-555] Currency Kit Updates Oct 22, 2024
@jasperfurniss jasperfurniss marked this pull request as ready for review October 22, 2024 19:53
@jasperfurniss jasperfurniss requested review from a team as code owners October 22, 2024 19:53
@jasperfurniss jasperfurniss self-assigned this Oct 22, 2024
@jasperfurniss jasperfurniss added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 22, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.6.0.pre.alpha.PBNTR5554217

Your Alpha for NPM is 14.6.0-alpha.PBNTR5554217

nidaqg
nidaqg previously approved these changes Oct 23, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Oct 23, 2024
@jasperfurniss jasperfurniss added alpha and removed alpha labels Oct 24, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.6.0.pre.alpha.PBNTR5554223

Your Alpha for NPM is 14.6.0-alpha.PBNTR5554223

@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-555

@jasperfurniss jasperfurniss added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit 27c5726 Oct 30, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-555 branch October 30, 2024 18:33
jasperfurniss added a commit that referenced this pull request Oct 30, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants