Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-389](Dropdown work - States & Variant Prop [ 1 of 5]) #3828

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Oct 18, 2024

PBNTR-389

This PR adds new state styles and a variant prop with a subtle doc example!

Screenshot 2024-09-30 at 2 04 45 PM

How to test? Steps to confirm the desired behavior:

  1. Go to the dropdown kit and confirm styles!

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 18, 2024
@nickamantia nickamantia self-assigned this Oct 18, 2024
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-389-dropdown-states-and-variant

@nickamantia nickamantia marked this pull request as ready for review October 18, 2024 18:54
@nickamantia nickamantia requested review from a team as code owners October 18, 2024 18:54
@nidaqg nidaqg added Code Approved Approved by a Playbook Admin Product Approved pending technical review, OK to merge to master labels Oct 18, 2024
@nidaqg nidaqg added this pull request to the merge queue Oct 22, 2024
Merged via the queue into master with commit f4c5e2f Oct 22, 2024
9 checks passed
@nidaqg nidaqg deleted the pbntr-389-dropdown-states-and-variant branch October 22, 2024 19:36
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.6.0.pre.rc.22
- NPM: 14.6.0-rc.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants