[PLAY-1586] Timeline Sub Sub Components #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdoeswork
added
the
milano
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1586datearea |
markdoeswork
added
enhancement
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.5.0.pre.alpha.play1586datearea4115 Your Alpha for NPM is 14.5.0-alpha.play1586datearea4115 |
markdoeswork
commented
Oct 17, 2024
playbook/app/pb_kits/playbook/pb_timeline/docs/_timeline_with_children.html.erb
Outdated
Show resolved
Hide resolved
|
@markdoeswork Hey Mark! I went ahead and threw my feedback into a gist: the gist |
playbook/app/pb_kits/playbook/pb_timeline/docs/_timeline_with_children.md
Outdated
Show resolved
Hide resolved
jasperfurniss
previously approved these changes
Oct 30, 2024
nidaqg
previously approved these changes
Oct 31, 2024
playbook/app/pb_kits/playbook/pb_timeline/docs/_timeline_with_children.md
Outdated
Show resolved
Hide resolved
markdoeswork
added
milano
jasperfurniss
added
the
Ready for Release
jasperfurniss
approved these changes
Nov 5, 2024
markdoeswork
added
milano
markdoeswork
added
milano
|
You merged this pr to master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1586
In this story we let devs add children or "what ever kit they want" to the date and node area of the timeline kit
The major changes to react is in the
playbook/app/pb_kits/playbook/pb_timeline/_item.tsxand in rails i added a new pattern to be able to conditionally render fragments of contentI have an alpha here https://github.com/powerhome/nitro-web/pull/43266
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.