-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAY-1581] Height, minHeight, maxHeight for Card, Flex, FlexItem, & Dialog #3749
Conversation
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.5.0.pre.alpha.PLAY15814040 Your Alpha for NPM is 14.5.0-alpha.PLAY15814040 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're adding these inline props to kit_base.rb
, doesn't that mean we're adding these props to all Ruby kits?
Otherwise, looks really good to me! Clean, effective, and simple.
I've also got a few questions / comments which I've added.
@kangaree We are only adding these to kits that use pb_content_tag. But none of it should be getting used/applied yet. Did your screen shot show up automatically in a doc example? Or did you implement code to make that happen. |
@jasperfurniss I checked out this branch and in
Edit: We talked in Connect and the plan moving forward we've got makes sense. This isn't applied to all ruby kits. |
@kangaree Ah! Perfect! Then yes, you're ahead of the game, and testing the "beta" stuff that we aren't advertising for use yet. This will likely be a 1 of 2 ...or 1 of 3 story setup for this work. Thanks for testing that out! |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.5.0.pre.alpha.PLAY15814066 Your Alpha for NPM is 14.5.0-alpha.PLAY15814066 |
What does this PR do? A clear and concise description with your runway ticket url.
https://runway.powerhrg.com/backlog_items/PLAY-1581
In order to achieve the height functionality that the story demanded, we introduced a new utility function for handling specific global properties that require dynamic values (any px, %, or vh, etc). This has been on our Todo list for a looooong time, and I'm so happy we were able to knock out the work here in this story!
The work in this PR adds the following props for react: minHeight, maxHeight, height for React
The work in this PR adds the following props for rails: min_height, max_height, height for Rails
For now, these are applied to a few of our utility kits: Card, Flex, FlexItem, Dialog
We have a path forward to apply to all other kits, but for now this work unblocks the Template work for the PB-In-Nitro team, without shipping changes to every kit which would move this to a much higher risk-level.
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.