[PBNTR-523] Enable Kits Instead of Text for Radio label - React Only #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.3.2.pre.alpha.pbntr523enablekitsforradiofix3809 Your Alpha for NPM is 14.3.2-alpha.pbntr523enablekitsforradiofix3809 |
nickamantia
added
the
enhancement
nickamantia
added
the
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.4.0.pre.alpha.pbntr523enablekitsforradiofix3825 Your Alpha for NPM is 14.4.0-alpha.pbntr523enablekitsforradiofix3825 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.4.0.pre.alpha.pbntr523enablekitsforradiofix3826 Your Alpha for NPM is 14.4.0-alpha.pbntr523enablekitsforradiofix3826 |
nidaqg
approved these changes
Sep 23, 2024
nidaqg
added
Code Approved
nidaqg
pushed a commit
that referenced
this pull request
Sep 26, 2024
**What does this PR do?** A clear and concise description with your runway ticket url. Copy the new URL from the original idea in Tempo [PR #3691](powerhome/tempo#3691) **Screenshots:** Screenshots to visualize your addition/change **How to test?** Steps to confirm the desired behavior: 1. Go to a Milano environment 2. Click on "More" in the top right, and then "logs" 3. Logs won't appear because the URL needs to change #### Checklist: - [ ] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [ ] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code.
nickamantia
added a commit
that referenced
this pull request
Oct 18, 2024
…3691) [PBNTR-523](https://runway.powerhrg.com/backlog_items/PBNTR-523) This PR adds the ability to pass in a kit as a child to the Radio kit. When the child is clicked, it will check off that Radio button.  **How to test?** Steps to confirm the desired behavior: 1. Go to `/kits/radio/react` to confirm functionality. #### Checklist: - [ ] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [ ] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBNTR-523
This PR adds the ability to pass in a kit as a child to the Radio kit. When the child is clicked, it will check off that Radio button.
How to test? Steps to confirm the desired behavior:
/kits/radio/reactto confirm functionality.Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.