Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-490] Fixing minimizing the dropdown when clicking outside #3688

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

carloslimasd
Copy link
Contributor

@carloslimasd carloslimasd commented Sep 12, 2024

What does this PR do?
Fixing dropdown doesn't minimize when clicking outside of the field.

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@carloslimasd carloslimasd added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano alpha labels Sep 12, 2024
@carloslimasd carloslimasd self-assigned this Sep 12, 2024
@carloslimasd carloslimasd requested review from a team as code owners September 12, 2024 20:22
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.3.2.pre.alpha.PBNTR490multilevelselect3766

Your Alpha for NPM is 14.3.2-alpha.PBNTR490multilevelselect3766

Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.3.2.pre.alpha.PBNTR490multilevelselect3771

Your Alpha for NPM is 14.3.2-alpha.PBNTR490multilevelselect3771

Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.4.0.pre.alpha.PBNTR490multilevelselect3832

Your Alpha for NPM is 14.4.0-alpha.PBNTR490multilevelselect3832

@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Sep 23, 2024
@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Sep 24, 2024
@nidaqg nidaqg added this pull request to the merge queue Sep 24, 2024
Merged via the queue into master with commit 5c8575d Sep 24, 2024
6 checks passed
@nidaqg nidaqg deleted the PBNTR-490-multi-level-select branch September 24, 2024 12:08
nickamantia pushed a commit that referenced this pull request Oct 18, 2024
**What does this PR do?**
Fixing dropdown doesn't minimize when clicking outside of the field.

**How to test?** Steps to confirm the desired behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See addition/change


#### Checklist:
- [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new
kit`, `deprecated`, or `breaking`. See [Changelog &
Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels)
for details.
- [x] **DEPLOY** I have added the `milano` label to show I'm ready for a
review.
- [ ] **TESTS** I have added test coverage to my code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants