Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBNTR-480] Implementing Radio custom children prop #3685

Merged
merged 4 commits into from
Sep 17, 2024
Merged

[PBNTR-480] Implementing Radio custom children prop #3685

merged 4 commits into from
Sep 17, 2024

Conversation

carloslimasd
Copy link
Contributor

@carloslimasd carloslimasd commented Sep 11, 2024 •
edited
Loading

What does this PR do?
Implement radio custom children prop for use kits instead of a text.

Screenshots:
image

How to test? Steps to confirm the desired behavior:

  1. Go to the Radio kit doc page.
  2. Scroll down to the Custom Children doc example.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@carloslimasd carloslimasd added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Sep 11, 2024
@carloslimasd carloslimasd self-assigned this Sep 11, 2024
@carloslimasd carloslimasd requested review from a team as code owners September 11, 2024 15:09
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-480-radio-custom-children-prop

@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.3.2.pre.alpha.PBNTR480radiocustomchildrenprop3759

Your Alpha for NPM is 14.3.2-alpha.PBNTR480radiocustomchildrenprop3759

jasperfurniss
jasperfurniss previously approved these changes Sep 12, 2024
View reviewed changes
@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master Code Approved Approved by a Playbook Admin labels Sep 16, 2024
@jasperfurniss jasperfurniss removed the Code Approved Approved by a Playbook Admin label Sep 16, 2024
@jasperfurniss jasperfurniss self-requested a review September 16, 2024 15:57
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Sep 17, 2024
@nidaqg nidaqg added this pull request to the merge queue Sep 17, 2024
Merged via the queue into master with commit d071cca Sep 17, 2024
6 checks passed
@nidaqg nidaqg deleted the PBNTR-480-radio-custom-children-prop branch September 17, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidaqg nidaqg nidaqg approved these changes

@jasperfurniss jasperfurniss Awaiting requested review from jasperfurniss

Assignees

@carloslimasd carloslimasd

Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carloslimasd @jasperfurniss @nidaqg