-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-515] Remove margin bottom from Typeahead kit, un-revert PBNTR-479 #3680
Conversation
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.3.1.pre.alpha.PBNTR515typeaheadmarginbottomredux3746 Your Alpha for NPM is 14.3.1-alpha.PBNTR515typeaheadmarginbottomredux3746 |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.3.1.pre.alpha.PBNTR515typeaheadmarginbottomredux3747 Your Alpha for NPM is 14.3.1-alpha.PBNTR515typeaheadmarginbottomredux3747 |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.3.1.pre.alpha.PBNTR515typeaheadmarginbottomredux3751 Your Alpha for NPM is 14.3.1-alpha.PBNTR515typeaheadmarginbottomredux3751 |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.3.1.pre.alpha.PBNTR515typeaheadmarginbottomredux3752 Your Alpha for NPM is 14.3.1-alpha.PBNTR515typeaheadmarginbottomredux3752 |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.3.1.pre.alpha.PBNTR515typeaheadmarginbottomredux3750 Your Alpha for NPM is 14.3.1-alpha.PBNTR515typeaheadmarginbottomredux3750 |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.3.2.pre.alpha.PBNTR515typeaheadmarginbottomredux3756 Your Alpha for NPM is 14.3.2-alpha.PBNTR515typeaheadmarginbottomredux3756 |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.3.2.pre.alpha.PBNTR515typeaheadmarginbottomredux3785 Your Alpha for NPM is 14.3.2-alpha.PBNTR515typeaheadmarginbottomredux3785 |
What does this PR do? A clear and concise description with your runway ticket url.
PBNTR-515 is attempt #2 at PBNTR-479, which had to be reverted from the Playbook 14.3.1 release due to an issue found in ninja testing where the Creatable-async-data typeahead used here (nitroqa link, component code link) did not work.
The change to the React in this PR vs PBNTR-479 mirrors the Rails version of the code much more closely - I realized that there was no need to pass the
marginBottom
prop from the Typeahead.tsx component to it's Control.tsx subcomponent because themarginBottom="none"
in the subcomponent was being applied to a TextInput, not to anything Typeahead related (so no need to pass props).Steps for PR completion:
Screenshots: Screenshots to visualize your addition/change
Rails margin bottom doc example
React margin bottom doc example
Datepicker dark mode margin bottom doc example works (compare vs current prod)
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.