Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1428] Fix Undefined Method Error in SamplesController#show #3675

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

skduncan
Copy link
Contributor

@skduncan skduncan commented Sep 9, 2024

What does this PR do? A clear and concise description with your runway ticket url.
https://runway.powerhrg.com/backlog_items/PLAY-1428

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@skduncan skduncan added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Sep 9, 2024
@skduncan skduncan requested review from a team as code owners September 9, 2024 13:26
Copy link
Contributor

@markdoeswork markdoeswork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective fix, nice tests too

@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master Code Approved Approved by a Playbook Admin and removed Needs Review labels Sep 12, 2024
@nidaqg nidaqg added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit 2926aac Sep 13, 2024
10 checks passed
@nidaqg nidaqg deleted the PLAY-1428_samples_undefined_method_error branch September 13, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants