Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-529] Children for MultiLevelSelect #3661

Merged
merged 11 commits into from
Oct 4, 2024

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Sep 6, 2024

Runway Story

This PR:

  • ✅ Creates MultiLevelSelect.Options subcomponent
  • ✅ Backwards compatible so none subcomponent structure also works
  • ✅ Render children next to Checkbox/Radios
Screenshot 2024-10-01 at 9 41 45 PM Screenshot 2024-10-01 at 9 42 02 PM

@nidaqg nidaqg added the milano 20 MAX - Deploy this PR to a review environment via Milano label Sep 6, 2024
@nidaqg nidaqg self-assigned this Sep 6, 2024
@nidaqg nidaqg reopened this Sep 26, 2024
@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) and removed do not merge labels Sep 26, 2024
@nidaqg nidaqg changed the title [PBNTR-374] Children for MultiLevelSelect [PBNTR-529] Children for MultiLevelSelect Oct 2, 2024
@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 2, 2024
@nidaqg nidaqg marked this pull request as ready for review October 2, 2024 01:42
@nidaqg nidaqg requested review from a team as code owners October 2, 2024 01:42
@nidaqg nidaqg added the alpha label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.5.0.pre.alpha.PBNTR374multilevelselectPOC3946

Your Alpha for NPM is 14.5.0-alpha.PBNTR374multilevelselectPOC3946

jasperfurniss
jasperfurniss previously approved these changes Oct 2, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Oct 2, 2024
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-374-multilevelselect-poc

@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Oct 3, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Oct 4, 2024
Merged via the queue into master with commit caa3c8a Oct 4, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-374-multilevelselect-POC branch October 4, 2024 17:24
Copy link

github-actions bot commented Oct 4, 2024

You merged this pr to master branch:
- Ruby Gem: 14.6.0.pre.rc.6
- NPM: 14.6.0-rc.6

nickamantia pushed a commit that referenced this pull request Oct 18, 2024
[Runway Story](https://runway.powerhrg.com/backlog_items/PBNTR-529)

This PR:
- ✅ Creates MultiLevelSelect.Options subcomponent
- ✅ Backwards compatible so none subcomponent structure also works
- ✅ Render children next to Checkbox/Radios

<img width="855" alt="Screenshot 2024-10-01 at 9 41 45 PM"
src="https://github.com/user-attachments/assets/20ff1dac-0173-4e0e-8396-ed43d70c530c">

<img width="825" alt="Screenshot 2024-10-01 at 9 42 02 PM"
src="https://github.com/user-attachments/assets/f5fa5c6f-e4fd-4409-a53f-5ef838dc53d3">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants