Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1405] Create a Doc for Border Radius Global Props #3534

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

ElisaShapiro
Copy link
Contributor

@ElisaShapiro ElisaShapiro commented Jul 18, 2024

What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1405 updates the Border Radius Tokens and Guidelines page to include more information about how to use this global prop on our kits by including a global prop table and an "example in use." It now also links to the Card kit's border radius doc example.

Screenshots: Screenshots to visualize your addition/change
border radius global props section

How to test? Steps to confirm the desired behavior:

  1. Go to the Border Radius page in Tokens & Guidelines in the review environment here.
  2. See addition of link to Card kit's border radius doc examples and the new global props section with the border radius token values and an example in use.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
    - [ ] TESTS I have added test coverage to my code.

@ElisaShapiro ElisaShapiro added the improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) label Jul 18, 2024
@ElisaShapiro ElisaShapiro self-assigned this Jul 18, 2024
@ElisaShapiro ElisaShapiro added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jul 19, 2024
@ElisaShapiro ElisaShapiro marked this pull request as ready for review July 19, 2024 15:17
@ElisaShapiro ElisaShapiro requested review from a team as code owners July 19, 2024 15:17
@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Jul 19, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Jul 19, 2024
@nidaqg nidaqg added this pull request to the merge queue Jul 19, 2024
Merged via the queue into master with commit 1698cd4 Jul 19, 2024
7 checks passed
@nidaqg nidaqg deleted the PLAY-1405-border-radius-global-prop-doc branch July 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants