-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAY-1435] Fix Dark Mode Styles: Collapsible Kit #3530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonymig88
added
the
bug
Fixes to issues discovered in Playbook (USED IN CHANGELOG)
label
Jul 17, 2024
anthonymig88
added
the
milano
20 MAX - Deploy this PR to a review environment via Milano
label
Jul 19, 2024
anthonymig88
added
milano
20 MAX - Deploy this PR to a review environment via Milano
and removed
milano
20 MAX - Deploy this PR to a review environment via Milano
labels
Jul 23, 2024
nidaqg
added
the
Product Approved
pending technical review, OK to merge to master
label
Jul 24, 2024
nidaqg
reviewed
Jul 24, 2024
playbook/app/pb_kits/playbook/pb_collapsible/docs/_collapsible_custom_main.jsx
Outdated
Show resolved
Hide resolved
nidaqg
reviewed
Jul 24, 2024
playbook/app/pb_kits/playbook/pb_collapsible/docs/_collapsible_custom_main_rails.html.erb
Show resolved
Hide resolved
Replaced Background Kit with the Flex Kit to match our Rails implementation.
Updates React side to match Rails side!
anthonymig88
added
milano
20 MAX - Deploy this PR to a review environment via Milano
and removed
milano
20 MAX - Deploy this PR to a review environment via Milano
labels
Jul 25, 2024
anthonymig88
added
milano
20 MAX - Deploy this PR to a review environment via Milano
and removed
milano
20 MAX - Deploy this PR to a review environment via Milano
labels
Jul 25, 2024
nidaqg
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes to issues discovered in Playbook (USED IN CHANGELOG)
milano
20 MAX - Deploy this PR to a review environment via Milano
Product Approved
pending technical review, OK to merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the Collapsible Kit:
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.