Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1435] Fix Dark Mode Styles: Collapsible Kit #3530

Merged
merged 12 commits into from
Jul 26, 2024

Conversation

anthonymig88
Copy link
Contributor

@anthonymig88 anthonymig88 commented Jul 17, 2024

What does this PR do?
In the Collapsible Kit:

  • Under Custom Icons [React]: The icon wasn't visible on half the time (Looked correct in light mode)
  • Under Custom Main [Rails/React]: The title had a white background with default text
  • Under Custom Main with Icon [Rails/React]: The title had a background and the icon isn't showing up against the white background in dark mode
  • Under useCollapsible Hook [React]: The nested icons were using light mode instead of dark mode

Screenshots: Screenshots to visualize your addition/change
Screenshot 2024-07-17 at 11 42 25 AM
Screenshot 2024-07-19 at 12 26 03 PM
Screenshot 2024-07-19 at 12 23 26 PM
Screenshot 2024-07-19 at 12 26 59 PM

How to test? Steps to confirm the desired behavior:

  1. Go to Playbook --> Collapsible Kit
  2. Click on Custom Icons dropdown to prove working
  3. Scroll down to Custom Main and Custom Main with Icon to verify visual appeal in dark mode
  4. Scroll down to Collapsible Hook to verify visual appeal in dark mode

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@anthonymig88 anthonymig88 added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label Jul 17, 2024
@anthonymig88 anthonymig88 self-assigned this Jul 17, 2024
@anthonymig88 anthonymig88 added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jul 19, 2024
@anthonymig88 anthonymig88 marked this pull request as ready for review July 19, 2024 16:23
@anthonymig88 anthonymig88 requested review from a team as code owners July 19, 2024 16:23
@anthonymig88 anthonymig88 added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 23, 2024
@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Jul 24, 2024
Replaced Background Kit with the Flex Kit to match our Rails implementation.
Updates React side to match Rails side!
@anthonymig88 anthonymig88 added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 25, 2024
@anthonymig88 anthonymig88 added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 25, 2024
@nidaqg nidaqg added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit 4c04a55 Jul 26, 2024
5 checks passed
@nidaqg nidaqg deleted the play-1435-fix-darkmode-collapsible-kit branch July 26, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants