[PLAY-1436] Dark Mode Fix: Contact and DRI #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonymig88
added
bug
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1436-darkmode-fix-contact-and-dri |
nickamantia
added
improvement
carloslimasd
previously approved these changes
Jul 15, 2024
anthonymig88
added
milano
nickamantia
reviewed
Jul 16, 2024
playbook/app/pb_kits/playbook/pb_bar_graph/docs/_bar_graph_custom.md
Outdated
Show resolved
Hide resolved
nidaqg
added
the
Product Approved
nidaqg
reviewed
Jul 18, 2024
playbook/app/pb_kits/playbook/pb_date_range_inline/_date_range_inline.tsx
Show resolved
Hide resolved
anthonymig88
added
milano
nidaqg
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLAY-1436
What does this PR do?
Text for the Contact kit was not swapping over to the light text color and staying as default darker grey. Fixed now in both Rails and React. Also the date range inline icons for the body text were not swapping over to the lighter white color in react only.
Screenshots:
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.