[PLAY-1414] ViteJS Update #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestephenmarshall
added
the
milano
thestephenmarshall
force-pushed
the
PLAY-1414
branch
from
395572a to
501b3bd
Compare
thestephenmarshall
force-pushed
the
PLAY-1414
branch
from
c2ae6b0 to
64b0f95
Compare
3 tasks
thestephenmarshall
force-pushed
the
PLAY-1414
branch
from
730f8e9 to
2a809cc
Compare
thestephenmarshall
force-pushed
the
PLAY-1414
branch
from
21816c5 to
25ad7a0
Compare
[release story](https://runway.powerhrg.com/backlog_items/PLAY-1459) --------- Co-authored-by: Jasper Furniss <[email protected]>
thestephenmarshall
force-pushed
the
PLAY-1414
branch
from
48dd981 to
46b2cc6
Compare
jasperfurniss
approved these changes
Aug 2, 2024
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
…ding SCSS Variables (e.g., $z_10) (#3608) **What does this PR do?** - ✅ Fix `@import playbook.scss` errors. Allow theming (e.g., set $z_10). - ✅ Remove [PLAY-1414](#3520) `calc()` functions that causes undefined variable errors. - ✅ Simplify by using standard SCSS calculations instead of calc() throughout playbook - ✅ Copy and use intl-tel-input node_modules CSS file so it works with SCSS. - ✅ Update "how to theme" doc - ✅ Prepare rails-react-example for PB 14.0.0 upgrade (add nullish coalescing operator to babel config) **How to test?** Steps to confirm the desired behavior: 1. Go to /kits page 2. Review and look for major style breaking changes #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. --------- Co-authored-by: Carlos Lima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.