Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1402] hide beta versions of kits within Kit Categories (with menu.yml) #3513

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

ElisaShapiro
Copy link
Contributor

@ElisaShapiro ElisaShapiro commented Jul 9, 2024

What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1402 ensures that beta kits are not visible on the kit_category pages of the Playbook website. This includes both PB/kit_category/category_title and PB/beta/kit_category/category_title endpoints. This PR also continues some work started in PLAY-1391 runway/PR to fully update name -> category for beta website pages based on the change to menu.yml.

The stretch goal 🌟 in the runway ticket was also achieved: menu_yml_spec.rb contains some basic tests to confirm the YAML file loads without errors, that categories and components are properly defined, and that each component has a name and a platform. Runs with rspec playbook-website/test/menu_yml_spec.rb from playbook folder.

Screenshots: Screenshots to visualize your addition/change:
Note - for these screenshots I temporarily made several kits beta on my local for the sake of a clear visual demonstration. Dialog, Button Toolbar, and Circle Icon Button are beta in the examples below.
Kits are beta - Dialog and Button Toolbar kit pages have beta kit card, not listed on sidebar:
for PR dialog is beta
for PR button toolbar is beta
All Kits pages - beta kits do not appear:
for PR all kits no dialog
for PR all kits no buttons
Kit Category pages - beta kits do not appear:
for PR kit category no dialog
for PR kit category no buttons
Beta All Kits page - beta kits do not appear, even when searched for in the filter input:
for PR beta all kits no dialog or buttons
for PR beta all kits search buttons
Beta Kit Category pages - beta kits do not appear:
for PR beta kit category no dialog
for PR beta kit category no buttons

How to test? Steps to confirm the desired behavior:
Note: in the milano review environment, Draggable is the only beta kit and should be used as the test kit.

  1. Go to beta kit page in review env.
  2. See that Draggable has the beta kit card and is not listed on sidebar under the "Layout & Structure" category.
  3. Click on the "Layout & Structure" sidebar or go to kit category page in review env
  4. Scroll down the page and see that Draggable is not present on the kit_category page.
  5. Go to the beta kits website page and scroll down to the "Layout & Structure" category section.
  6. Click on the "Layout & Structure" category title (URL will display https://pr3513.playbook.beta.gm.powerapp.cloud/beta/kit_category/layout_and_structure), see that Draggable is not present on the beta/kit_category page.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@ElisaShapiro ElisaShapiro added the improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) label Jul 9, 2024
@ElisaShapiro ElisaShapiro self-assigned this Jul 9, 2024
@ElisaShapiro ElisaShapiro added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jul 10, 2024
@ElisaShapiro ElisaShapiro marked this pull request as ready for review July 10, 2024 20:43
@ElisaShapiro ElisaShapiro requested review from a team as code owners July 10, 2024 20:43
@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Jul 18, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Jul 18, 2024
@nidaqg nidaqg added this pull request to the merge queue Jul 19, 2024
Merged via the queue into master with commit bf42b51 Jul 19, 2024
8 checks passed
@nidaqg nidaqg deleted the PLAY-1402-hide-beta-kits-from-kit-category-page branch July 19, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants