[PLAY-1402] hide beta versions of kits within Kit Categories (with menu.yml) #3513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1402 ensures that beta kits are not visible on the kit_category pages of the Playbook website. This includes both PB/kit_category/category_title and PB/beta/kit_category/category_title endpoints. This PR also continues some work started in PLAY-1391 runway/PR to fully update name -> category for beta website pages based on the change to menu.yml.
The stretch goal 🌟 in the runway ticket was also achieved:
menu_yml_spec.rb
contains some basic tests to confirm the YAML file loads without errors, that categories and components are properly defined, and that each component has a name and a platform. Runs withrspec playbook-website/test/menu_yml_spec.rb
from playbook folder.Screenshots: Screenshots to visualize your addition/change:
Note - for these screenshots I temporarily made several kits beta on my local for the sake of a clear visual demonstration. Dialog, Button Toolbar, and Circle Icon Button are beta in the examples below.
Kits are beta - Dialog and Button Toolbar kit pages have beta kit card, not listed on sidebar:
All Kits pages - beta kits do not appear:
Kit Category pages - beta kits do not appear:
Beta All Kits page - beta kits do not appear, even when searched for in the filter input:
Beta Kit Category pages - beta kits do not appear:
How to test? Steps to confirm the desired behavior:
Note: in the milano review environment, Draggable is the only beta kit and should be used as the test kit.
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.