Skip to content

Commit

Permalink
Updated doc ex copy for popoverProps implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
ElisaShapiro committed Oct 21, 2024
1 parent d5b4de5 commit e79d3e2
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<%=
pb_rails("filter", props: {
id: "filter_custom_width_rails",
id: "filter_popover_props",
position: "top",
filters: [
{ name: "name", value: "John Wick" },
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import { Button, Filter, Flex, Select, TextInput } from 'playbook-ui'

const FilterCustomWidth = (props) => {
const FilterPopoverProps = (props) => {
const options = [
{ value: 'USA' },
{ value: 'Canada' },
Expand Down Expand Up @@ -68,4 +68,4 @@ const FilterCustomWidth = (props) => {
)
}

export default FilterCustomWidth
export default FilterPopoverProps
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This kit uses the [Popover kit](https://playbook.powerapp.cloud/kits/popover) under the hood for the Filter Popover which comes with its own set of props. If you want to apply certain Popover props to that underlying kit, you can do so by using the optional `popover_props` prop. This prop must be an object that contains valid Popover props. For a full list of Popover props, see [here](https://playbook.powerapp.cloud/kits/popover).
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This kit uses the [Popover kit](https://playbook.powerapp.cloud/kits/popover/react) under the hood for the Filter Popover which comes with its own set of props. If you want to apply certain Popover props to that underlying kit, you can do so by using the optional `popoverProps` prop. This prop must be an object that contains valid Popover props. For a full list of Popover props, see [here](https://playbook.powerapp.cloud/kits/popover/react).
4 changes: 2 additions & 2 deletions playbook/app/pb_kits/playbook/pb_filter/docs/example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ examples:
- sort_only: Sort Only
- filter_max_width: Max Width for Popover Inside of Filter
- filter_max_height: Max Height for Popover Inside of Filter
- filter_custom_width: Custom Width for Popover Inside of Filter
- filter_placement: Filter Placement
- filter_popover_props: Popover Props

react:
- filter_default: Default
Expand All @@ -21,6 +21,6 @@ examples:
- sort_only: Sort Only
- filter_max_width: Max Width for Popover Inside of Filter
- filter_max_height: Max Height for Popover Inside of Filter
- filter_custom_width: Custom Width for Popover Inside of Filter
- filter_placement: Filter Placement
- filter_popover_props: Popover Props

2 changes: 1 addition & 1 deletion playbook/app/pb_kits/playbook/pb_filter/docs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ export { default as SortOnly } from './_sort_only.jsx'
export { default as FilterMaxWidth } from './_filter_max_width.jsx'
export { default as FilterMaxHeight } from './_filter_max_height.jsx'
export { default as FilterPlacement } from './_filter_placement.jsx'
export { default as FilterCustomWidth } from './_filter_custom_width.jsx'
export { default as FilterPopoverProps } from './_filter_popover_props.jsx'

0 comments on commit e79d3e2

Please sign in to comment.