Skip to content

Commit

Permalink
[PLAY-1613] Fix Dark Mode Date Colors- Dots, Icons, and Captions (#3894)
Browse files Browse the repository at this point in the history
**What does this PR do?** A clear and concise description with your
runway ticket url.
Use $text_dk_light for dark mode Date kit caption and body: fix dots,
icons, and captions.

**Screenshots:** Screenshots to visualize your addition/change
<img width="152" alt="Screenshot 2024-11-07 at 2 53 21 PM"
src="https://github.com/user-attachments/assets/caa2537d-ea19-4b77-b668-f8e415755b90">

**How to test?** Steps to confirm the desired behavior:
1. Go to /kits/date/
2. Turn on dark mode
3. Look at the variants doc example
4. The "dot" should be a dark mode color
5. Same for the calendar icon, and the first example listed
6. Review React, Rails, and make sure the light mode isn't affected at
all.

#### Checklist:
- [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new
kit`, `deprecated`, or `breaking`. See [Changelog &
Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels)
for details.
- [x] **DEPLOY** I have added the `milano` label to show I'm ready for a
review.
  • Loading branch information
kangaree authored Nov 13, 2024
1 parent bb8e4fa commit 1356072
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions playbook/app/pb_kits/playbook/pb_date/_date.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,8 @@
[class^=pb_title_kit] {
color: $text_dk_default !important;
}
[class^=pb_body_kit], [class^=pb_caption_kit] {
color: $text_dk_light !important;
}
}
}

0 comments on commit 1356072

Please sign in to comment.