Dropdown rails to have postion absolute on container

powerhome · Nov 20, 2024 · 1271c56 · 1271c56
1 parent 251118d
commit 1271c56
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/playbook/app/pb_kits/playbook/pb_dropdown/_dropdown.scss b/playbook/app/pb_kits/playbook/pb_dropdown/_dropdown.scss
@@ -53,6 +53,7 @@
     }
 
     .pb_dropdown_container {
+      position: absolute;
       background-color: $white;
       overflow: hidden;
       box-shadow: $shadow_deep;

diff --git a/playbook/app/pb_kits/playbook/pb_dropdown/dropdown_container.html.erb b/playbook/app/pb_kits/playbook/pb_dropdown/dropdown_container.html.erb
@@ -1,10 +1,8 @@
-<%= content_tag(:div,
+<%= pb_content_tag(:div,
     aria: object.aria,
     class: object.classname,
     data: object.data,
-    id: object.id,
-    style: object.container_style,
-    **combined_html_options) do %>
+    id: object.id) do %>
     <%= pb_rails("list", props: {ordered: false, borderless: false}) do %>
             <% if content.present? %> 
                 <%= content.presence %>

diff --git a/playbook/app/pb_kits/playbook/pb_dropdown/dropdown_container.rb b/playbook/app/pb_kits/playbook/pb_dropdown/dropdown_container.rb
@@ -7,10 +7,6 @@ def classname
         generate_classname("pb_dropdown_container", "close", separator: " ")
       end
 
-      def container_style
-        "position: absolute"
-      end
-
       def data
         Hash(prop(:data)).merge(dropdown_container: true)
       end