Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBIOS-624] Popover investigation #473

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

isismsilva
Copy link
Contributor

@isismsilva isismsilva commented Nov 21, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Findings:

macOS
Implementation Feasibility:

  • It is possible to implement a popover component that inherits macOS native popover functionalities and behavior.

Customization:

  • Some UI aspects can be customized, enabling closer alignment with the Playbook UI design.
  • Certain attributes, such as the popover's border and shadow, are not customizable due to limitations in the macOS framework.

Conclusion:
While not all design elements are fully controllable, leveraging native macOS functionality provides robust behavior and ease of integration.

iOS
Implementation Feasibility:

  • Direct reuse of macOS popover implementation is not possible due to framework differences between iOS and macOS.

Customization:

  • A custom popover view can be recreated to match the expected UI closely.
  • Achieving desired popover behaviors (e.g., interaction dynamics, positioning) requires additional programming and more complex logic.

Conclusion:
A custom implementation can meet design and functional requirements but involves higher development complexity.

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist

  • LABELS - Add a label: breaking, bug, improvement, documentation, or enhancement. See Labels for descriptions.
  • RELEASES - Add the appropriate label: Ready for Testing / Ready for Release
  • TESTING - Have you tested your story?

@isismsilva isismsilva added the Ready for Testing For anything that needs testing label Nov 21, 2024
@isismsilva isismsilva self-assigned this Nov 21, 2024
@isismsilva isismsilva requested a review from a team as a code owner November 21, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Testing For anything that needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant