Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display better error message for missing credentials #27

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Display better error message for missing credentials #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d0a5a1
Display better error message for missing credentials
stephenagreer Sep 19, 2023
5b4e9f3
Linting
stephenagreer Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/omniauth/strategies/base_strategy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ module OmniAuth
module Strategies
class BaseStrategy < OmniAuth::Strategies::OpenIDConnect
class APIError < StandardError; end
class ClientCredentialsError < StandardError; end

def public_key
@public_key ||= if options.discovery
Expand All @@ -18,6 +19,13 @@ def public_key
end
end

def client
super
rescue AttrRequired::AttrMissing
raise ClientCredentialsError,
"#{options[:name].camelize} client credentials not found. Please check your environment."
end

def self.decode_logout_token(token)
jwks = fetch_jwks
JSON::JWT.decode(token, jwks)
Expand Down