Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOAT] Make manual mutes count towards rule -1 #75

Open
wants to merge 2 commits into
base: my-awesome-branch
Choose a base branch
from

Conversation

BenSegal855
Copy link
Contributor

This PR keeps track of mutes which are applied without the use of the enforce command. Mutes applied using the mute command and manual role management are included. They are stored in the enforce collection under rule -1 just like muted leaves are.

*note: I had to change the tsconfig target, lib, and module keys to es2020 to get the bot to run even before my changes. This change is not included in this PR as the existing esnext configuration may work fine on other systems

@cyyynthia cyyynthia self-assigned this Jul 15, 2021
@cyyynthia cyyynthia added the enhancement New feature or request label Jul 15, 2021
@cyyynthia
Copy link
Collaborator

I'm honestly unsure if I'm fine with this implementation or not; other than code style issues (import type transformed into import), I feel like this implementation is rather dirty (and this honestly applies to behavior already relying on this, just that having multiple unrelated bits kind of "glued" with this hacky thing is even worse)

as of your tsconfig issues, you just have an outdated node version. (node 15+ required).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants