Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting signatures to be compatible with 18.10 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adjusting signatures to be compatible with 18.10 #3

wants to merge 1 commit into from

Conversation

tobiaszeuch
Copy link 

* adding parameter $blocktypename to function get_css_icon
* adding type BlockInstance to function instance_config_form
* adding type Pieform to function save_config_option
* adding parameter $versioning=false in function render_instance

@tobiaszeuch
Adjusting signatures to be compatible with 18.10
25ae654 
    * adding parameter $blocktypename to function get_css_icon
    * adding type BlockInstance to function instance_config_form
    * adding type Pieform to function save_config_option
    * adding parameter $versioning=false in function render_instance
@tobiaszeuch
Copy link
Author

As far as I was able to verify without a Linkedin api key, these changes are also compatible with version 19.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tobiaszeuch